jasperjiaguo commented on code in PR #12969: URL: https://github.com/apache/pinot/pull/12969#discussion_r1572738611
########## pinot-spi/pom.xml: ########## @@ -33,6 +33,7 @@ <url>https://pinot.apache.org/</url> <properties> <pinot.root>${basedir}/..</pinot.root> + <shade.phase.prop>package</shade.phase.prop> Review Comment: changed to disabled by default and tested with mvn build, can you take another look @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
