Jackie-Jiang commented on code in PR #12886:
URL: https://github.com/apache/pinot/pull/12886#discussion_r1577304282
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##########
@@ -76,22 +79,52 @@ void init(InstanceDataManagerConfig
instanceDataManagerConfig, TableConfig table
boolean isShutDown();
+ /**
+ * Returns the segment lock for a segment in the table.
+ */
+ Lock getSegmentLock(String segmentName);
+
+ /**
+ * Returns whether the segment is loaded in the table.
+ */
+ boolean hasSegment(String segmentName);
+
/**
* Adds a loaded immutable segment into the table.
*/
+ @VisibleForTesting
void addSegment(ImmutableSegment immutableSegment);
Review Comment:
That requires refactoring some classes. I think we can do it separately.
Added some more javadoc explaining it is not designed for direct use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
