gortiz commented on PR #12704: URL: https://github.com/apache/pinot/pull/12704#issuecomment-2075217016
> Can you share the race condition you find during debugging? I want to learn the context If found it in https://github.com/apache/pinot/pull/12704/commits/dcb197cd5469824f30aeaaab0c54a5ef40246ec2, whose tests are still in https://github.com/apache/pinot/actions/runs/8659408355/job/23754450579. But previous commits failed in other cases. Basically it looks like there is a concurrency issue if we remove the Synchronized map in `StatMap`. Specifically, I was able to reproduce it by running one of the test that failed 1000 times in a loop. After a couple of minutes it failed. In that case, it always failed in the stats of the leaf operator. In that operator I modify the StatMap in the constructor. I have to say that in that version of the code the StatMap was initialized in the super class, so maybe the constructor with final attribute was not applying by then. Now that it applies, it may be the case that we don't need to actually synchronize, but I wouldn't feel very comfortable relaying on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
