gortiz commented on code in PR #12982:
URL: https://github.com/apache/pinot/pull/12982#discussion_r1578961848
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##########
@@ -102,7 +107,23 @@ public enum BrokerMeter implements AbstractMetrics.Meter {
NETTY_CONNECTION_BYTES_RECEIVED("nettyConnection", true),
PROACTIVE_CLUSTER_CHANGE_CHECK("proactiveClusterChangeCheck", true),
- DIRECT_MEMORY_OOM("directMemoryOOMCount", true);
+ DIRECT_MEMORY_OOM("directMemoryOOMCount", true),
+
+
+ /**
+ * Number of multi-stage queries that have been started.
+ * <p>
+ * Unlike {@link #MULTI_STAGE_QUERIES_BY_TABLE}, this metric is global and
not attached to a particular table.
+ * That means it can be used to know how many multi-stage queries have been
started in total.
+ */
+ MULTI_STAGE_QUERIES_EXECUTED("queries", true),
Review Comment:
> Also way may put them next to QUERIES
In general I try to avoid to change the order of literals to make sure
backward compatibility is not broken, but I think in this case it is fine to do
it.
Changing it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
