Jackie-Jiang commented on code in PR #12966:
URL: https://github.com/apache/pinot/pull/12966#discussion_r1581326170
##########
pinot-plugins/pinot-input-format/pinot-parquet/src/test/java/org/apache/pinot/plugin/inputformat/parquet/ParquetNativeRecordReaderFullTest.java:
##########
@@ -123,19 +123,22 @@ protected void testReadDataSet2()
//testParquetFile("test-data2/uniform_encryption.parquet.encrypted");
}
- protected void testParquetFile(String filePath)
+protected void testParquetFile(String filePath)
throws Exception {
File dataFile = new
File(URLDecoder.decode(getClass().getClassLoader().getResource(filePath).getFile(),
"UTF-8"));
ParquetNativeRecordReader recordReader = new ParquetNativeRecordReader();
recordReader.init(dataFile, null, null);
+ int counter = 0;
Review Comment:
E.g when the assert fails, it will leak resource because the last `close()`
won't be executed. Using try-with-resource is just good practice to prevent
resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
