aditya0811 commented on PR #12922: URL: https://github.com/apache/pinot/pull/12922#issuecomment-2081117418
The new test case in PR has `0.1f`, which breaks the existing test, however doesn't satisfy `floatValue != (float) Double.parseDouble(Float.toString(floatValue))`. We compare float(`_leftStorageType`) with double(`_rightStorageType`). For `_leftStorageType`, with implicit cast, the `float value=0.1f` is converted to `(double) value = 0.10000000149011612`. For `_rightStorageType`, we parse it as `double value= 0.1d`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
