jasperjiaguo commented on code in PR #13104:
URL: https://github.com/apache/pinot/pull/13104#discussion_r1592964029
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java:
##########
@@ -152,12 +153,6 @@ void receiveDataTable(ServerRoutingInstance
serverRoutingInstance, DataTable dat
ServerResponse response = _responseMap.get(serverRoutingInstance);
response.receiveDataTable(dataTable, responseSize, deserializationTimeMs);
- // Record query completion stats immediately after receiving the response
from the server instead of waiting
Review Comment:
IIUC if we remove this discount upon each `receiveDataTable` and rely only
on the one in `getFinalResponses`, it means the performance of all fan out
servers are determined by the slowest one among them, do you think it would
case inaccuracy where we over estimate the load on some servers whenever a
timeout happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
