ankitsultana commented on code in PR #13092:
URL: https://github.com/apache/pinot/pull/13092#discussion_r1593220973
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -659,6 +659,11 @@ private List<String> scheduleTask(PinotTaskGenerator
taskGenerator, List<TableCo
try {
if (numTasks > 0) {
// This might lead to lot of logs, maybe sum it up and move outside
the loop
+ if
(_pinotHelixResourceManager.getInstancesWithTag(minionInstanceTag).isEmpty()) {
+ LOGGER.error("Skipping {} tasks for task type: {} with task
configs: {} to invalid minionInstance: {}",
Review Comment:
nit: `to invalid minionInstanceTag`
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -659,6 +659,11 @@ private List<String> scheduleTask(PinotTaskGenerator
taskGenerator, List<TableCo
try {
if (numTasks > 0) {
// This might lead to lot of logs, maybe sum it up and move outside
the loop
Review Comment:
comment should be before `LOGGER.info`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
