Jackie-Jiang commented on code in PR #13113:
URL: https://github.com/apache/pinot/pull/13113#discussion_r1599178475
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##########
@@ -194,7 +194,7 @@ private String getShardIterator(String shardId, String
sequenceNumber) {
requestBuilder = requestBuilder.startingSequenceNumber(sequenceNumber)
.shardIteratorType(ShardIteratorType.AFTER_SEQUENCE_NUMBER);
} else {
- requestBuilder =
requestBuilder.shardIteratorType(_config.getShardIteratorType());
+ requestBuilder =
requestBuilder.shardIteratorType(_config.getInitShardIteratorType());
Review Comment:
Reading through the code again and I'm a little bit confused. In what
scenario will we get `null` sequenceNumber?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
