yashmayya commented on code in PR #13166:
URL: https://github.com/apache/pinot/pull/13166#discussion_r1602957690
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/SetOpNode.java:
##########
@@ -57,7 +57,7 @@ public boolean isAll() {
@Override
public String explain() {
- return _setOpType.toString();
+ return _all ? _setOpType.toString() + "_ALL" : _setOpType.toString();
Review Comment:
Yeah it does look like this attribute is always true for the union set
operation (i.e., regardless of whether we use `UNION` or `UNION ALL`). I guess
that isn't inaccurate though since the actual semantics being implemented are
indeed the `UNION ALL` semantics and the logical plan also contains
`LogicalUnion(all=[true])` for both `UNION` and `UNION ALL`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
