ankitsultana commented on code in PR #13170:
URL: https://github.com/apache/pinot/pull/13170#discussion_r1604053220
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManagerTest.java:
##########
@@ -153,12 +157,12 @@ public void testStartFinishOperation() {
@Test
public void testAddReplaceRemoveSegment()
throws IOException {
- verifyAddReplaceRemoveSegment(HashFunction.NONE, false);
- verifyAddReplaceRemoveSegment(HashFunction.MD5, false);
- verifyAddReplaceRemoveSegment(HashFunction.MURMUR3, false);
- verifyAddReplaceRemoveSegment(HashFunction.NONE, true);
- verifyAddReplaceRemoveSegment(HashFunction.MD5, true);
- verifyAddReplaceRemoveSegment(HashFunction.MURMUR3, true);
+ verifyAddReplaceRemoveSegment(NoOpHashFunction.INSTANCE, false);
+ verifyAddReplaceRemoveSegment(MD5UpsertHashFunction.INSTANCE, false);
+ verifyAddReplaceRemoveSegment(Murmur3UpsertHashFunction.INSTANCE, false);
Review Comment:
self-review: forgot to update the test `testHashPrimaryKeys`. We can also
remove `HashUtils`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
