Jackie-Jiang commented on code in PR #13168:
URL: https://github.com/apache/pinot/pull/13168#discussion_r1605913372
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -699,6 +699,10 @@ public static class Server {
public static final String CONFIG_OF_SEGMENT_STORE_URI =
"segment.store.uri";
public static final String CONFIG_OF_LOGGER_ROOT_DIR =
"pinot.server.logger.root.dir";
+ public static final String
CONFIG_OF_REALTIME_SEGMENT_CONSUMER_CLIENT_ID_SUFFIX =
+ "realtime.consumer.client.id.suffix";
+ public static final String
DEFAULT_REALTIME_SEGMENT_CONSUMER_CLIENT_ID_SUFFIX = "";
Review Comment:
We usually use `null` if there is no default setting for a config. You may
directly call
`_serverConfig.getProperty(CONFIG_OF_REALTIME_SEGMENT_CONSUMER_CLIENT_ID_SUFFIX);`
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/instance/InstanceDataManagerConfig.java:
##########
@@ -39,6 +39,8 @@ public interface InstanceDataManagerConfig {
String getSegmentStoreUri();
+ String getRealtimeSegmentConsumerClientIdSuffix();
Review Comment:
```suggestion
String getConsumerClientIdSuffix();
```
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -699,6 +699,10 @@ public static class Server {
public static final String CONFIG_OF_SEGMENT_STORE_URI =
"segment.store.uri";
public static final String CONFIG_OF_LOGGER_ROOT_DIR =
"pinot.server.logger.root.dir";
+ public static final String
CONFIG_OF_REALTIME_SEGMENT_CONSUMER_CLIENT_ID_SUFFIX =
+ "realtime.consumer.client.id.suffix";
Review Comment:
More concise since real-time is implicit for consumer
```suggestion
"consumer.client.id.suffix";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
