yashmayya opened a new pull request, #13193: URL: https://github.com/apache/pinot/pull/13193
- This patch adds a backward compatibility regression test suite for the multi-stage query engine. It uses the framework added in https://github.com/apache/pinot/pull/6129, https://github.com/apache/pinot/pull/6650, https://github.com/apache/pinot/issues/4001 and extends it to use the multi-stage query engine with queries like joins, windows, and set operations. - We're using a separate new test suite for now because we only want to run the multi-stage query engine backward compatibility tests against `master` whereas the existing tests currently run against `release-1.0.0`, `release-1.1.0` and `master`. - We can't currently run these multi-stage query engine backward compatibility tests against older releases because there are already known breakages in backward compatibility between these releases. Going forward, however, we want to maintain backward compatibility in the multi-stage query engine as well, which is why these tests are being added. - Future releases `release-1.2.0` , `release-1.3.0` etc. will be added to the list of branches that the multi-stage query engine backward compatibility tests are run against. - These new tests use the existing framework for backward compatibility regression tests and hence run tests with these scenarios using a single controller, broker, and server setup: - Controller on older version, Broker on older version, Server on older version - Controller on newer version, Broker on older version, Server on older version - Controller on newer version, Broker on newer version, Server on older version - Controller on newer version, Broker on newer version, Server on newer version - Ideally, for the multi-stage query engine, we'd want to test for multi-server scenarios as well (where different servers are running different versions). Support for this will be added in a future patch. The current tests help catch compatibility issues between Broker <-> Server interactions. - Note that a new GitHub Actions workflow file has been created for the multi-stage query engine compatibility regression tests since currently we don't want to run it against older versions whereas we'd still want to run the regular compatibility regression test suite against older versions (for instance, during releases). - Once we reach a state where we have multiple released versions where backward compatibility has been maintained for the multi-stage query engine, we can merge the two compatibility regression test suites and run them against the same versions. - Suggested labels: `testing` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
