Jackie-Jiang commented on code in PR #13198:
URL: https://github.com/apache/pinot/pull/13198#discussion_r1608948106
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNativeV2.java:
##########
@@ -83,6 +84,16 @@ public ResultTable getResultTable() {
@Override
public void setResultTable(@Nullable ResultTable resultTable) {
_resultTable = resultTable;
+ // NOTE: Update _numRowsResultSet when setting non-null result table. We
might set null result table when user wants
+ // to hide the result but only show the stats, in which case we
should not update _numRowsResultSet.
+ if (resultTable != null) {
+ _numRowsResultSet = resultTable.getRows().size();
+ }
+ }
+
+ @Override
+ public int getNumRowsResultSet() {
+ return _numRowsResultSet;
Review Comment:
I didn't add it intentionally because we want to always set it along with
the result table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
