eaugene commented on code in PR #13195:
URL: https://github.com/apache/pinot/pull/13195#discussion_r1609292514
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/AccessControl.java:
##########
@@ -48,7 +50,7 @@ default boolean hasAccess(RequesterIdentity
requesterIdentity) {
*
* @return {@code true} if authorized, {@code false} otherwise
*/
- boolean hasAccess(RequesterIdentity requesterIdentity, BrokerRequest
brokerRequest);
+ AuthorizationResult hasAccess(RequesterIdentity requesterIdentity,
BrokerRequest brokerRequest);
Review Comment:
Currently, this method is only used in a single-stage engine. However,
according to the Javadoc, it is can also used in columns, permissions, etc.
Therefore, I am making it compatible to send messages to the REST controller
level.
Sure , will ensure this change is backwards compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
