itschrispeck commented on code in PR #13199:
URL: https://github.com/apache/pinot/pull/13199#discussion_r1610736806
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java:
##########
@@ -60,12 +63,21 @@ protected BlockDocIdSet getFalses() {
List<BlockDocIdSet> blockDocIdSets = new
ArrayList<>(_filterOperators.size());
for (BaseFilterOperator filterOperator : _filterOperators) {
if (filterOperator.isResultEmpty()) {
+ blockDocIdSets.add(EmptyDocIdSet.getInstance());
+ continue;
+ }
+ if (filterOperator.isResultMatchingAll()) {
blockDocIdSets.add(new MatchAllDocIdSet(_numDocs));
Review Comment:
good points!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
