This is an automated email from the ASF dual-hosted git repository.

xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 256d0aa5a5 Do not pause ingestion when upsert snapshot flow errors out 
(#13257)
256d0aa5a5 is described below

commit 256d0aa5a566a4c6605a1a02ba3972c05a60fcb7
Author: Pratik Tibrewal <[email protected]>
AuthorDate: Thu May 30 04:51:36 2024 +0530

    Do not pause ingestion when upsert snapshot flow errors out (#13257)
    
    * Do not pause ingestion when snapshot flow errors out
---
 .../pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java  | 2 ++
 1 file changed, 2 insertions(+)

diff --git 
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
 
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
index 001ce1d091..7c133b8af0 100644
--- 
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
+++ 
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
@@ -847,6 +847,8 @@ public abstract class BasePartitionUpsertMetadataManager 
implements PartitionUps
       long duration = System.currentTimeMillis() - startTime;
       _serverMetrics.addTimedTableValue(_tableNameWithType, 
ServerTimer.UPSERT_SNAPSHOT_TIME_MS, duration,
           TimeUnit.MILLISECONDS);
+    } catch (Exception e) {
+      _logger.warn("Caught exception while taking snapshot", e);
     } finally {
       _snapshotLock.writeLock().unlock();
       finishOperation();


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to