This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 3dd653a785 [bugfix] Handling null value for kafka client id suffix 
(#13279)
3dd653a785 is described below

commit 3dd653a7859f39698fa99f727cc27bb1a6aa60d1
Author: Pratik Tibrewal <[email protected]>
AuthorDate: Sat Jun 1 06:02:04 2024 +0530

    [bugfix] Handling null value for kafka client id suffix (#13279)
---
 .../core/data/manager/realtime/RealtimeSegmentDataManager.java     | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
 
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
index b441f086de..bcc3223141 100644
--- 
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
+++ 
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
@@ -1435,11 +1435,12 @@ public class RealtimeSegmentDataManager extends 
SegmentDataManager {
     _acquiredConsumerSemaphore = new AtomicBoolean(false);
     InstanceDataManagerConfig instanceDataManagerConfig = 
_indexLoadingConfig.getInstanceDataManagerConfig();
     String clientIdSuffix =
-        instanceDataManagerConfig != null ? 
instanceDataManagerConfig.getConsumerClientIdSuffix() : "";
+        instanceDataManagerConfig != null ? 
instanceDataManagerConfig.getConsumerClientIdSuffix() : null;
     if (StringUtils.isNotBlank(clientIdSuffix)) {
-      clientIdSuffix = "-" + clientIdSuffix;
+      _clientId = _tableNameWithType + "-" + streamTopic + "-" + 
_partitionGroupId + "-" + clientIdSuffix;
+    } else {
+      _clientId = _tableNameWithType + "-" + streamTopic + "-" + 
_partitionGroupId;
     }
-    _clientId = _tableNameWithType + "-" + streamTopic + "-" + 
_partitionGroupId + clientIdSuffix;
     _segmentLogger = 
LoggerFactory.getLogger(RealtimeSegmentDataManager.class.getName() + "_" + 
_segmentNameStr);
     _tableStreamName = _tableNameWithType + "_" + streamTopic;
     if (_indexLoadingConfig.isRealtimeOffHeapAllocation() && 
!_indexLoadingConfig.isDirectRealtimeOffHeapAllocation()) {


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to