Jackie-Jiang commented on code in PR #13292:
URL: https://github.com/apache/pinot/pull/13292#discussion_r1623296248
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -191,7 +191,13 @@ public void processSqlWithMultiStageQueryEngineGet(
executeSqlQuery(requestJson, makeHttpIdentity(requestContext), true,
httpHeaders, true);
asyncResponse.resume(getPinotQueryResponse(brokerResponse));
} catch (WebApplicationException wae) {
- asyncResponse.resume(wae);
+ Response response = wae.getResponse();
Review Comment:
Trying to understand the difference here. Should we always `resume` on the
response instead of the exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
