Jackie-Jiang commented on code in PR #13266:
URL: https://github.com/apache/pinot/pull/13266#discussion_r1625084505
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/cleanup/SchemaCleanupTaskStatelessTest.java:
##########
@@ -97,6 +97,7 @@ public void teardown() {
public void testSchemaCleanupTask()
throws Exception {
PinotMetricUtils.cleanUp();
+ PinotMetricUtils.getPinotMetricsRegistry();
Review Comment:
What we usually do is to call
`ControllerMetrics.register(mock(ControllerMetrics.class));` in the test set up
annotated as `@BeforeClass`. You may find more examples if you check the usage
of `ServerMetrics.register()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
