Jackie-Jiang commented on code in PR #13249:
URL: https://github.com/apache/pinot/pull/13249#discussion_r1625169434


##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -823,6 +827,59 @@ public String uploadLLCSegment(
     }
   }
 
+  @POST
+  @Path("/tables/{realtimeTableName}/consumingSegmentsFreshnessInfo")
+  @Authorize(targetType = TargetType.TABLE, paramName = "realtimeTableName",
+      action = Actions.Table.GET_SEGMENTS_FRESHNESS)
+  @Produces(MediaType.APPLICATION_JSON)
+  @ApiOperation(value = "Returns ingestion timestamp ms for given segments",
+      notes = "Any segments that are not consuming will be excluded")
+  @ApiResponses(value = {
+      @ApiResponse(code = 200, message = "Success"),
+      @ApiResponse(code = 404, message = "Table not found"),
+      @ApiResponse(code = 500, message = "Internal server error")
+  })
+  public Map<String, Long> getSegmentsFreshnessInfo(

Review Comment:
   I guess we can provide 2 APIs (or combining 2 functionalities into one API), 
one returning the per partition info, one return the table level info. The API 
should only take the table name as input



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to