Jackie-Jiang commented on code in PR #13131:
URL: https://github.com/apache/pinot/pull/13131#discussion_r1626460234
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -128,10 +128,10 @@ private TableConfigUtils() {
RoutingConfig.MULTI_STAGE_REPLICA_GROUP_SELECTOR_TYPE);
/**
- * @see TableConfigUtils#validate(TableConfig, Schema, String, boolean)
+ * @see TableConfigUtils#validate(TableConfig, Schema, String, boolean,
boolean)
*/
public static void validate(TableConfig tableConfig, @Nullable Schema
schema) {
- validate(tableConfig, schema, null, false);
+ validate(tableConfig, schema, null, false, false);
Review Comment:
These are always instance level/cluster level config, so it should be good
to have them as `static` (basically model it as a singleton validator). We may
add 2 static methods `setDisableGroovy()` and
`setEnforcePoolBasedAssignment()`, and set them up in the `ControllerStarter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
