shounakmk219 commented on code in PR #13290:
URL: https://github.com/apache/pinot/pull/13290#discussion_r1627830416
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/server.yml:
##########
@@ -73,6 +66,14 @@ rules:
table: "$1$3"
tableType: "$4"
partition: "$5"
+- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ServerMetrics\",
name=\"pinot\\.server\\.endToEndRealtimeIngestionDelayMs\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\\.(\\w+)\"><>(\\w+)"
Review Comment:
Yeah. `realtimeIngestionDelayMs` is handled by moving the metric rule
earlier present on line 16 to line 175.
Will add screenshots on validation as well
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/server.yml:
##########
@@ -171,6 +172,14 @@ rules:
name: "pinot_server_grpc$1_$2"
cache: true
+- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ServerMetrics\",
name=\"pinot\\.server\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\\.(\\w+)\"><>(\\w+)"
+ name: "pinot_server_$5_$6"
+ cache: true
+ labels:
+ database: "$2"
+ table: "$1$3"
Review Comment:
replied above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
