tibrewalpratik17 commented on code in PR #13285:
URL: https://github.com/apache/pinot/pull/13285#discussion_r1630122807
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -1111,6 +1132,9 @@ protected void addDocId(IndexSegment segment,
ThreadSafeMutableRoaringBitmap val
try {
doAddDocId(validDocIds, queryableDocIds, docId, recordInfo);
} finally {
+ if (_enableSnapshot) {
Review Comment:
> I'd suggest to move this if-block outside the critical section of
upsertViewLock
Actually this is not inside upsertViewLock. I just wanted to keep it in the
finally block so that we add the updated segment to the set always.
> btw, it may help to comment that we don't need to take snasphotLock when
updating this Set (IIUC)
yeah we don't need snapshotLock here at all while updating this Set. Will
add a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
