gortiz commented on code in PR #13418:
URL: https://github.com/apache/pinot/pull/13418#discussion_r1643904537
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -828,20 +828,26 @@ public void run() {
_segmentLogger.info("Could not commit segment. Retrying after
hold");
hold();
break;
+ }
default:
_segmentLogger.error("Holding after response from Controller:
{}", response.toJsonString());
hold();
break;
}
}
} catch (Exception e) {
- String errorMessage = "Exception while in work";
- _segmentLogger.error(errorMessage, e);
- postStopConsumedMsg(e.getClass().getName());
- _state = State.ERROR;
- _realtimeTableDataManager.addSegmentError(_segmentNameStr, new
SegmentErrorInfo(now(), errorMessage, e));
- _serverMetrics.setValueOfTableGauge(_clientId,
ServerGauge.LLC_PARTITION_CONSUMING, 0);
- return;
+ if (_shouldStop) {
+ _segmentLogger.info("Caught exception in consumer thread after
stop() is invoked: {}, ignoring the exception",
+ e.toString());
Review Comment:
This will not print the stack trace. Shouldn't be better to print it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
