Jackie-Jiang commented on code in PR #13425:
URL: https://github.com/apache/pinot/pull/13425#discussion_r1644905496


##########
pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java:
##########
@@ -399,6 +400,8 @@ private static DataType getDataType(Expression expression, 
Schema schema) {
         dataType = DataType.INT;
       } else if ("VARCHAR".equals(targetTypeLiteral)) {
         dataType = DataType.STRING;
+      } else if (targetTypeLiteral.endsWith("_ARRAY")) {

Review Comment:
   Good catch! Should we perform this before getting into the if checks? This 
way we can also handle things like `INTEGER_ARRAY` etc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to