vrajat commented on code in PR #13361:
URL: https://github.com/apache/pinot/pull/13361#discussion_r1665249021
##########
pinot-common/src/main/java/org/apache/pinot/common/broker/BrokerSelector.java:
##########
@@ -28,6 +29,10 @@ public interface BrokerSelector {
*/
String selectBroker(String... tableNames);
+ default BrokerInfo selectBrokerInfo(String... tableName) {
+ throw new UnsupportedOperationException("selectBrokerInfo has not been
implemented.");
Review Comment:
Agree - this is confusing. I dont see the point in enforcing `BrokerInfo`
on `ControllerBasedBrokerSelector` and `SimpleBrokerSelector`. It actually
makes the code more convoluted. Instead I am considering splitting into two
interfaces `BrokerUrlSelector` and `BrokerInfoSelector`. I'll see how the code
turns out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
