shounakmk219 commented on code in PR #13560:
URL: https://github.com/apache/pinot/pull/13560#discussion_r1669167353
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -89,15 +87,13 @@ public class SegmentStatusChecker extends
ControllerPeriodicTask<SegmentStatusCh
*/
public SegmentStatusChecker(PinotHelixResourceManager
pinotHelixResourceManager,
LeadControllerManager leadControllerManager, ControllerConf config,
ControllerMetrics controllerMetrics,
- ExecutorService executorService) {
+ TableSizeReader tableSizeReader) {
super("SegmentStatusChecker", config.getStatusCheckerFrequencyInSeconds(),
config.getStatusCheckerInitialDelayInSeconds(),
pinotHelixResourceManager, leadControllerManager,
controllerMetrics);
_waitForPushTimeSeconds =
config.getStatusCheckerWaitForPushTimeInSeconds();
- _tableSizeReader =
- new TableSizeReader(executorService, new
PoolingHttpClientConnectionManager(), _controllerMetrics,
Review Comment:
Is it ok to use the shared connectionManager here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
