aishikbh commented on code in PR #13540:
URL: https://github.com/apache/pinot/pull/13540#discussion_r1670824868
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileManager.java:
##########
@@ -99,12 +101,18 @@ public void closeFileWriter()
/**
* Returns the file reader. Creates one if not exists.
*/
- public GenericRowFileReader getFileReader()
+ public GenericRowReader getFileReader()
throws IOException {
if (_fileReader == null) {
Preconditions.checkState(_offsetFile.exists(), "Record offset file: %s
does not exist", _offsetFile);
Preconditions.checkState(_dataFile.exists(), "Record data file: %s does
not exist", _dataFile);
- _fileReader = new GenericRowFileReader(_offsetFile, _dataFile,
_fieldSpecs, _includeNullFields, _numSortFields);
+ Map<String, Object> params = new HashMap<>();
Review Comment:
Unfortunately this can vary across readers, that's why decided to put it in
this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
