itschrispeck commented on code in PR #13577:
URL: https://github.com/apache/pinot/pull/13577#discussion_r1672858672
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##########
@@ -61,7 +65,9 @@ public TextIndexConfig(@JsonProperty("disabled") Boolean
disabled, @JsonProperty
@JsonProperty("luceneUseCompoundFile") Boolean luceneUseCompoundFile,
@JsonProperty("luceneMaxBufferSizeMB") Integer luceneMaxBufferSizeMB,
@JsonProperty("luceneAnalyzerClass") String luceneAnalyzerClass,
- @JsonProperty("enablePrefixSuffixMatchingInPhraseQueries") Boolean
enablePrefixSuffixMatchingInPhraseQueries) {
+ @JsonProperty("enablePrefixSuffixMatchingInPhraseQueries") Boolean
enablePrefixSuffixMatchingInPhraseQueries,
+ @JsonProperty("reuseMutableIndex") Boolean reuseMutableIndex,
+ @JsonProperty("enableNRTCachingDirectory") Boolean
enableNRTCachingDirectory) {
Review Comment:
We could use a config `luceneNRTCachingDirectoryBufferSize` instead of
reusing `luceneMaxBufferSizeMB` for the NRTCachingDirectory's size, which has
the benefit of allowing users to disable the functionality w/ size 0 as this
config does, and also adjust it independently of IndexWriter buffer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
