yashmayya commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1677706064
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -331,6 +331,12 @@ private TableAuthorizationResult
hasTableAccess(RequesterIdentity requesterIdent
* Returns true if the QPS quota of the tables has exceeded.
*/
private boolean hasExceededQPSQuota(Set<String> tableNames, RequestContext
requestContext) {
+ String database =
DatabaseUtils.extractDatabaseFromTableName(tableNames.iterator().next());
Review Comment:
Ah, and also this list of tables can be empty in literal only queries - see
https://github.com/apache/pinot/blob/1d788196d31793fe7209506c52b7c4424a43c0b3/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java#L634
which is failing in CI due to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
