dd-willgan opened a new pull request, #13609:
URL: https://github.com/apache/pinot/pull/13609

   Motivation: GitHub issue TBD
   
   Changes:
   - Refactor existing try catch blocks in TimestampUtils
   - Add 1 more try catch block after to try parsing string with 
DateTimeFormatter
     - Tried using java.text.SimpleDateFormat at first but ran into edge cases, 
saw that java.time.* is recommended
       - java.sql.Timestamp.valueOf also has a overload for LocalDateTime
   - Add TimestampUtilsTest
   
   Tested: Saw working locally 
   
   <img width="2555" alt="image" 
src="https://github.com/user-attachments/assets/14e3862d-70a2-4e7a-92f8-bd0624a6349d";>
   
   The following error is what was showing previously for `ts >= '2024-07-07'. 
Here is it expectedly showing for a badly formatted timestamp
   
   <img width="2554" alt="image" 
src="https://github.com/user-attachments/assets/8464a197-5c70-43f4-affd-eec25e61a00e";>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to