This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f74e8564af add assertion for S3PinotFS delete operation (#13607)
f74e8564af is described below
commit f74e8564afc6635f6644907b62fb8daa57744e76
Author: sullis <[email protected]>
AuthorDate: Mon Jul 15 15:04:36 2024 -0700
add assertion for S3PinotFS delete operation (#13607)
---
.../java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
a/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
b/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
index 339155643a..226254e769 100644
---
a/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
+++
b/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
@@ -256,7 +256,10 @@ public class S3PinotFSTest {
}
}
- _s3PinotFS.delete(URI.create(String.format(FILE_FORMAT, SCHEME, BUCKET,
fileToDelete)), false);
+ boolean deleteResult = _s3PinotFS.delete(
+ URI.create(String.format(FILE_FORMAT, SCHEME, BUCKET, fileToDelete)),
false);
+
+ Assert.assertTrue(deleteResult);
ListObjectsV2Response listObjectsV2Response =
_s3Client.listObjectsV2(S3TestUtils.getListObjectRequest(BUCKET, "",
true));
@@ -278,7 +281,10 @@ public class S3PinotFSTest {
createEmptyFile(folderName, fileName);
}
- _s3PinotFS.delete(URI.create(String.format(FILE_FORMAT, SCHEME, BUCKET,
folderName)), true);
+ boolean deleteResult = _s3PinotFS.delete(
+ URI.create(String.format(FILE_FORMAT, SCHEME, BUCKET, folderName)),
true);
+
+ Assert.assertTrue(deleteResult);
ListObjectsV2Response listObjectsV2Response =
_s3Client.listObjectsV2(S3TestUtils.getListObjectRequest(BUCKET, "",
true));
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
