yashmayya commented on PR #13618: URL: https://github.com/apache/pinot/pull/13618#issuecomment-2230469468
> As defined in [SqlOperator Calcite javadoc](https://calcite.apache.org/javadocAggregate/org/apache/calcite/sql/SqlOperator.html#isDeterministic()), a function is deterministic if and only if > > > Returns whether a call to this operator is guaranteed to always return the same result given the same operands; true is assumed by default. > > Which is not true in the case of `ARRAY_TO_MV` Technically, `ARRAY_TO_MV` _is_ deterministic right since it is guaranteed to always return the same result given the same operands? Essentially, we're never going to get a different result for something like `ARRAY_TO_MV(RandomAirports) = 'MFR'` when applied to the same row. Although this does seem to fix the issue described in https://github.com/apache/pinot/issues/13595, so as long as there are no other side effects, I guess we could live with this (especially considering that the `ARRAY_TO_MV` function itself is a bit of a hack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
