gortiz commented on code in PR #13573:
URL: https://github.com/apache/pinot/pull/13573#discussion_r1680795734
##########
pinot-query-runtime/src/test/resources/queries/UDFAggregates.json:
##########
@@ -150,15 +150,15 @@
},
{
"sql": "SELECT PERCENTILE_TDIGEST(float_col, 50),
PERCENTILE_TDIGEST(double_col, 5), PERCENTILE_TDIGEST(int_col, 75),
PERCENTILE_TDIGEST(long_col, 75) FROM {tbl}",
- "outputs": [[1.75, 1.0, 137, 137]]
+ "outputs": [[1.75, 1.0, 137.75, 137.75]]
Review Comment:
Here we are changing the return type, right? Couldn't this produce problems
in production? Does it only happen with PERCETILE_TDIGEST or are other
aggregations that can change their type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
