shounakmk219 commented on code in PR #13627:
URL: https://github.com/apache/pinot/pull/13627#discussion_r1682083161
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/MultipleTreesBuilder.java:
##########
@@ -127,8 +127,22 @@ private StarTreeIndexSeparator getSeparator()
throws Exception {
List<StarTreeV2Metadata> starTreeMetadataList = new
SegmentMetadataImpl(_indexDir).getStarTreeV2MetadataList();
if (starTreeMetadataList == null) {
+ LOGGER.error("No existing star-tree. Building all new start-trees.");
return null;
}
+
+ // log the existing and incoming star-tree configs
+ StringBuilder starTreeConfigsDiff = new StringBuilder();
+ starTreeConfigsDiff.append("Existing star-tree configs :");
+ for (StarTreeV2Metadata startree : starTreeMetadataList) {
+
starTreeConfigsDiff.append("\n").append(StarTreeV2BuilderConfig.fromMetadata(startree));
+ }
+ starTreeConfigsDiff.append("\n").append("Updated star-tree configs :");
+ for (StarTreeV2BuilderConfig startree : _builderConfigs) {
+ starTreeConfigsDiff.append("\n").append(startree);
+ }
+ LOGGER.error(starTreeConfigsDiff.toString());
Review Comment:
Got it. Will add some more logging there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
