gortiz commented on code in PR #13648:
URL: https://github.com/apache/pinot/pull/13648#discussion_r1682443140
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/DictionariesTest.java:
##########
@@ -534,35 +530,4 @@ private AbstractColumnStatisticsCollector
buildStatsCollector(String column, Dat
throw new IllegalArgumentException("Illegal data type for stats
builder: " + dataType);
}
}
-
- @Test
- public void clpStatsCollectorTest() {
- Schema schema = new Schema();
- schema.addField(new DimensionFieldSpec("column1", DataType.STRING, true));
- List<FieldConfig> fieldConfigList = new ArrayList<>();
- fieldConfigList.add(new FieldConfig("column1",
FieldConfig.EncodingType.RAW, Collections.EMPTY_LIST,
Review Comment:
Wouldn't be better to add an if that reads the architecture and throws
SkipException in case it is an ARM?
you can do that with
`org.apache.commons.lang3.ArchUtils.getProcessor().getType()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
