jasperjiaguo commented on code in PR #13583:
URL: https://github.com/apache/pinot/pull/13583#discussion_r1683365386
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java:
##########
@@ -268,4 +273,24 @@ public String getServerRoutingStats() {
private long getRequestId() {
return _requestIdGenerator.getAndIncrement();
}
+
+ @GET
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("/debug/threads/resourceUsage")
+ @Authorize(targetType = TargetType.CLUSTER, action =
Actions.Cluster.DEBUG_RESOURCE_USAGE)
+ @ApiOperation(value = "Get resource usage of threads")
+ public Collection<? extends ThreadResourceTracker> getThreadResourceUsage() {
+ ThreadResourceUsageAccountant threadAccountant =
Tracing.getThreadAccountant();
+ return threadAccountant.getThreadResources();
+ }
+
+ @GET
+ @Path("debug/queries/resourceUsage")
+ @Produces(MediaType.APPLICATION_JSON)
Review Comment:
do we need authz here as well?
##########
pinot-tools/src/main/java/org/apache/pinot/tools/utils/PinotConfigUtils.java:
##########
@@ -215,6 +216,27 @@ public static Map<String, Object>
generateMinionConf(String clusterName, String
return properties;
}
+ public static Map<String, Object> getResourceTrackingConf() {
+ Map<String, Object> configOverrides = new HashMap<>();
+
configOverrides.put(CommonConstants.Server.CONFIG_OF_ENABLE_THREAD_CPU_TIME_MEASUREMENT,
true);
+
configOverrides.put(CommonConstants.Server.CONFIG_OF_ENABLE_THREAD_ALLOCATED_BYTES_MEASUREMENT,
true);
+
configOverrides.put(CommonConstants.Broker.CONFIG_OF_ENABLE_THREAD_CPU_TIME_MEASUREMENT,
true);
+
configOverrides.put(CommonConstants.Broker.CONFIG_OF_ENABLE_THREAD_ALLOCATED_BYTES_MEASUREMENT,
true);
+
configOverrides.put(CommonConstants.Accounting.CONFIG_OF_ENABLE_THREAD_CPU_SAMPLING,
true);
+
configOverrides.put(CommonConstants.Accounting.CONFIG_OF_ENABLE_THREAD_MEMORY_SAMPLING,
true);
+
+ configOverrides.put(
+ CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX + "." +
CommonConstants.Accounting.CONFIG_OF_FACTORY_NAME,
+ PerQueryCPUMemAccountantFactory.class.getCanonicalName());
+ configOverrides.put(CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX + "."
+ + CommonConstants.Accounting.CONFIG_OF_ENABLE_THREAD_MEMORY_SAMPLING,
true);
+ configOverrides.put(CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX + "."
+ + CommonConstants.Accounting.CONFIG_OF_ENABLE_THREAD_CPU_SAMPLING,
false);
+ configOverrides.put(CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX + "."
+ + CommonConstants.Accounting.CONFIG_OF_OOM_PROTECTION_KILLING_QUERY,
true);
Review Comment:
Not sure how is this used in your code but do you want to add some more
configs esp those query killing thresholds here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
