mgranderath commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1683938498
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##########
@@ -184,4 +211,27 @@ public void cancel(Worker.CancelRequest request,
StreamObserver<Worker.CancelRes
// we always return completed even if cancel attempt fails, server will
self clean up in this case.
responseObserver.onCompleted();
}
+
+ private SslContext buildSslContext(TlsConfig tlsConfig) {
+ LOGGER.info("Building gRPC SSL context");
+ SslContext sslContext =
CLIENT_SSL_CONTEXTS_CACHE.computeIfAbsent(tlsConfig.hashCode(),
tlsConfigHashCode -> {
Review Comment:
Just for my own understanding; Why do we need to use a map for this? Is it
simply so in the rare case that we launch multiple `QueryServer` we don't
duplicate the SSLContexts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
