Jackie-Jiang commented on code in PR #13667:
URL: https://github.com/apache/pinot/pull/13667#discussion_r1685542202
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimestampUtils.java:
##########
@@ -34,6 +33,8 @@ public class TimestampUtils {
.parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0)
.parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0)
.toFormatter();
+ private static final DateTimeFormatter ISO8601_FORMATTER =
Review Comment:
Is it possible to merge it into the previous formatter, or it has to be
defined as a separate one?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimestampUtils.java:
##########
@@ -34,6 +33,8 @@ public class TimestampUtils {
.parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0)
.parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0)
.toFormatter();
+ private static final DateTimeFormatter ISO8601_FORMATTER =
+
DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss[.SSSSSS][.SSSSS][.SSSS][.SSS][.SS][.S]X");
Review Comment:
Do we need all these alternatives? Is there a easier way to define the
pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
