This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 55fd6d201a Change STREAM_DATA_LOSS to a gauge. (#13712)
55fd6d201a is described below
commit 55fd6d201a57cf733a0686fb4025a1d3aec875ad
Author: Rajat Venkatesh <[email protected]>
AuthorDate: Fri Aug 2 12:57:18 2024 +0530
Change STREAM_DATA_LOSS to a gauge. (#13712)
---
.../src/main/java/org/apache/pinot/common/metrics/ServerGauge.java | 1 +
.../src/main/java/org/apache/pinot/common/metrics/ServerMeter.java | 1 -
.../pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java | 3 ++-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git
a/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
b/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
index fb4eba3340..fa9f372823 100644
---
a/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
+++
b/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
@@ -51,6 +51,7 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
NETTY_POOLED_USED_HEAP_MEMORY("bytes", true),
NETTY_POOLED_ARENAS_DIRECT("arenas", true),
NETTY_POOLED_ARENAS_HEAP("arenas", true),
+ STREAM_DATA_LOSS("streamDataLoss", false),
/**
* The size of the small cache.
diff --git
a/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java
b/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java
index 49d1c0c7e9..8cadec6bfc 100644
---
a/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java
+++
b/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java
@@ -118,7 +118,6 @@ public enum ServerMeter implements AbstractMetrics.Meter {
LARGE_QUERY_RESPONSES_SENT("largeResponses", false),
TOTAL_THREAD_CPU_TIME_MILLIS("millis", false),
LARGE_QUERY_RESPONSE_SIZE_EXCEPTIONS("exceptions", false),
- STREAM_DATA_LOSS("streamDataLoss", false),
// Multi-stage
/**
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
index c26b2c14f3..5acd5d57ee 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
@@ -951,7 +951,7 @@ public class RealtimeSegmentDataManager extends
SegmentDataManager {
*/
private void reportDataLoss(MessageBatch messageBatch) {
if (messageBatch.hasDataLoss()) {
- _serverMetrics.addMeteredTableValue(_tableStreamName,
ServerMeter.STREAM_DATA_LOSS, 1L);
+ _serverMetrics.setValueOfTableGauge(_tableStreamName,
ServerGauge.STREAM_DATA_LOSS, 1L);
String message = String.format("Message loss detected in stream
partition: %s for table: %s startOffset: %s "
+ "batchFirstOffset: %s", _partitionGroupId, _tableNameWithType,
_startOffset,
messageBatch.getFirstMessageOffset());
@@ -1197,6 +1197,7 @@ public class RealtimeSegmentDataManager extends
SegmentDataManager {
*/
private void cleanupMetrics() {
_serverMetrics.removeTableGauge(_clientId,
ServerGauge.LLC_PARTITION_CONSUMING);
+ _serverMetrics.removeTableGauge(_clientId, ServerGauge.STREAM_DATA_LOSS);
}
protected void hold()
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
