gortiz commented on code in PR #13784:
URL: https://github.com/apache/pinot/pull/13784#discussion_r1711206027
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -3462,6 +3454,16 @@ public void testGroupByAggregationWithLimitZero(boolean
useMultiStageQueryEngine
testQuery("SELECT Origin, SUM(ArrDelay) FROM mytable GROUP BY Origin LIMIT
0");
}
+ @Test(dataProvider = "useBothQueryEngines")
+ public void testFilteredAggregationWithGroupByOrdering(boolean
useMultiStageQueryEngine)
+ throws Exception {
+ setUseMultiStageQueryEngine(useMultiStageQueryEngine);
+
+ // Test the ordering is correctly applied to the correct aggregation (the
one without FILTER clause)
Review Comment:
nit: I would just add a mention to #13749 in this comment so readers can
have more context.
We don't usually do that and it has been useful to me when reading other
open source projects I know less about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
