tibrewalpratik17 commented on code in PR #13347:
URL: https://github.com/apache/pinot/pull/13347#discussion_r1712724090
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManagerFactory.java:
##########
@@ -83,8 +82,14 @@ public static TableUpsertMetadataManager create(TableConfig
tableConfig,
metadataManagerClass, tableNameWithType), e);
}
} else {
- LOGGER.info("Creating ConcurrentMapTableUpsertMetadataManager for table:
{}", tableNameWithType);
- metadataManager = new ConcurrentMapTableUpsertMetadataManager();
+ if (upsertConfig.isEnableConsistentDeletes()) {
Review Comment:
Yes thanks Jackie for this suggestion! Looks neat now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
