egalpin commented on code in PR #13742:
URL: https://github.com/apache/pinot/pull/13742#discussion_r1716084206
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ExecutionStatsAggregator.java:
##########
@@ -70,10 +71,13 @@ public ExecutionStatsAggregator(boolean enableTrace) {
_enableTrace = enableTrace;
}
- public void aggregate(ServerRoutingInstance routingInstance, DataTable
dataTable) {
- TableType tableType = routingInstance.getTableType();
- String instanceName = routingInstance.getShortName();
+ public void aggregate(ServerRoutingInstance serverRoutingInstance, DataTable
dataTable) {
+ String instanceName = serverRoutingInstance.getShortName();
Map<String, String> metadata = dataTable.getMetadata();
+ TableType tableType = null;
+ if (metadata.get(DataTable.MetadataKey.TABLE.getName()) != null) {
+ tableType =
TableNameBuilder.getTableTypeFromTableName(metadata.get(DataTable.MetadataKey.TABLE.getName()));
Review Comment:
@jackjlli this is where we're still able to capture metrics like number of
distinct servers as well as per-table-type metrics. The table name is added to
DataTable metadata by the server via this PR, which enables disambiguating
metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
