gortiz commented on code in PR #13817:
URL: https://github.com/apache/pinot/pull/13817#discussion_r1716745360
##########
pinot-core/src/test/java/org/apache/pinot/queries/FluentQueryTest.java:
##########
@@ -101,11 +182,22 @@ public static class DeclaringTable {
_extraQueryOptions = extraQueryOptions;
}
+ /**
+ * Creates one segment on the first instance with the given content.
+ *
+ * @param content the content of the segment.
+ * @see OnFirstInstance#andSegment(String...) to learn more about the
content syntax
+ */
Review Comment:
That is a good question. The framework creates up to 2 servers. Each one is
an instance. Most tests won't care much about instances and would be happy
using only one, but if you have to test the reduce phase in the broker, it is
sometimes useful to receive data from two different instances.
I think that is something I should add in the javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
