This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ef3caa391f Fix controller port logging in quickstart (#13794)
ef3caa391f is described below
commit ef3caa391fe297ca405d39aa6b64b7fdecbe856f
Author: Pratik Tibrewal <[email protected]>
AuthorDate: Fri Aug 16 12:31:53 2024 +0530
Fix controller port logging in quickstart (#13794)
---
.../src/main/java/org/apache/pinot/tools/GitHubEventsQuickstart.java | 4 +++-
.../src/main/java/org/apache/pinot/tools/HybridQuickstart.java | 4 +++-
pinot-tools/src/main/java/org/apache/pinot/tools/Quickstart.java | 4 +++-
.../src/main/java/org/apache/pinot/tools/RealtimeQuickStart.java | 4 +++-
.../java/org/apache/pinot/tools/admin/command/ImportDataCommand.java | 2 +-
.../java/org/apache/pinot/tools/admin/command/QuickstartRunner.java | 2 +-
6 files changed, 14 insertions(+), 6 deletions(-)
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/GitHubEventsQuickstart.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/GitHubEventsQuickstart.java
index ef06dfcd41..1d34fda100 100644
---
a/pinot-tools/src/main/java/org/apache/pinot/tools/GitHubEventsQuickstart.java
+++
b/pinot-tools/src/main/java/org/apache/pinot/tools/GitHubEventsQuickstart.java
@@ -179,7 +179,9 @@ public class GitHubEventsQuickstart extends QuickStartBase {
printStatus(Color.YELLOW, prettyPrintResponse(runner.runQuery(q5)));
printStatus(Color.GREEN,
"***************************************************");
- printStatus(Color.GREEN, "You can always go to http://localhost:9000 to
play around in the query console");
+ printStatus(Color.GREEN,
+ String.format("You can always go to http://localhost:%d to play around
in the query console",
+ QuickstartRunner.DEFAULT_CONTROLLER_PORT));
}
private String getTableConfigFilePath() {
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/HybridQuickstart.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/HybridQuickstart.java
index e5bd332c2b..2fb859e25b 100644
--- a/pinot-tools/src/main/java/org/apache/pinot/tools/HybridQuickstart.java
+++ b/pinot-tools/src/main/java/org/apache/pinot/tools/HybridQuickstart.java
@@ -141,6 +141,8 @@ public class HybridQuickstart extends Quickstart {
printStatus(Color.YELLOW, "***** Realtime quickstart setup complete
*****");
runSampleQueries(runner);
- printStatus(Color.GREEN, "You can always go to http://localhost:9000 to
play around in the query console");
+ printStatus(Color.GREEN,
+ String.format("You can always go to http://localhost:%d to play around
in the query console",
+ QuickstartRunner.DEFAULT_CONTROLLER_PORT));
}
}
diff --git a/pinot-tools/src/main/java/org/apache/pinot/tools/Quickstart.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/Quickstart.java
index 0a615d09e1..b5894ca968 100644
--- a/pinot-tools/src/main/java/org/apache/pinot/tools/Quickstart.java
+++ b/pinot-tools/src/main/java/org/apache/pinot/tools/Quickstart.java
@@ -94,7 +94,9 @@ public class Quickstart extends QuickStartBase {
runSampleQueries(runner);
}
- printStatus(Color.GREEN, "You can always go to http://localhost:9000 to
play around in the query console");
+ printStatus(Color.GREEN,
+ String.format("You can always go to http://localhost:%d to play around
in the query console",
+ QuickstartRunner.DEFAULT_CONTROLLER_PORT));
}
protected int getNumQuickstartRunnerServers() {
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStart.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStart.java
index 89168d160b..d5033b4e90 100644
--- a/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStart.java
+++ b/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStart.java
@@ -125,6 +125,8 @@ public class RealtimeQuickStart extends QuickStartBase {
printStatus(Color.YELLOW, "***** Realtime quickstart setup complete
*****");
runSampleQueries(runner);
- printStatus(Color.GREEN, "You can always go to http://localhost:9000 to
play around in the query console");
+ printStatus(Color.GREEN,
+ String.format("You can always go to http://localhost:%d to play around
in the query console",
+ QuickstartRunner.DEFAULT_CONTROLLER_PORT));
}
}
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/ImportDataCommand.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/ImportDataCommand.java
index 7b85106060..60414ee08e 100644
---
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/ImportDataCommand.java
+++
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/ImportDataCommand.java
@@ -76,7 +76,7 @@ public class ImportDataCommand extends
AbstractBaseAdminCommand implements Comma
private String _table;
@CommandLine.Option(names = {"-controllerURI"}, description = "Pinot
Controller URI.")
- private String _controllerURI = "http://localhost:9000";;
+ private String _controllerURI = String.format("http://localhost:%d";,
QuickstartRunner.DEFAULT_CONTROLLER_PORT);
@CommandLine.Option(names = {"-user"}, required = false, description =
"Username for basic auth.")
private String _user;
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java
index e1e80e8ae0..c0845a616c 100644
---
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java
+++
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java
@@ -48,7 +48,7 @@ public class QuickstartRunner {
private static final int ZK_PORT = 2123;
private static final String ZK_ADDRESS = "localhost:" + ZK_PORT;
- private static final int DEFAULT_CONTROLLER_PORT = 9000;
+ public static final int DEFAULT_CONTROLLER_PORT = 9000;
private static final int DEFAULT_BROKER_PORT = 8000;
private static final int DEFAULT_SERVER_ADMIN_API_PORT = 7500;
private static final int DEFAULT_SERVER_NETTY_PORT = 7050;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
