gortiz commented on code in PR #13839:
URL: https://github.com/apache/pinot/pull/13839#discussion_r1721607440
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/mapper/SegmentMapper.java:
##########
@@ -95,7 +95,8 @@ public SegmentMapper(List<RecordReaderFileConfig>
recordReaderFileConfigs,
tableConfig.getIndexingConfig().getSortedColumn());
_fieldSpecs = pair.getLeft();
_numSortFields = pair.getRight();
- _includeNullFields =
tableConfig.getIndexingConfig().isNullHandlingEnabled();
+ _includeNullFields =
+ schema.isEnableColumnBasedNullHandling() ||
tableConfig.getIndexingConfig().isNullHandlingEnabled();
Review Comment:
This is one of the two expected changes in semantic. This means that when
`SegmentMapper` is used with column based null handling it will keep null
values when writing rows. The main issue is that it will treat all columns as
nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
