vvivekiyer commented on code in PR #13792:
URL: https://github.com/apache/pinot/pull/13792#discussion_r1722078595
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -2776,6 +2776,18 @@ public void testNonAggregationGroupByQuery(boolean
useMultiStageQueryEngine)
h2Query = "SELECT CAST(ArrTime-DepTime AS FLOAT) FROM mytable GROUP BY
CAST(ArrTime-DepTime AS FLOAT)";
testQuery(pinotQuery, h2Query);
+ pinotQuery = "SELECT ArrTime-DepTime FROM mytable GROUP BY ArrTime,
DepTime LIMIT 1000000";
Review Comment:
We should also define the behavior for a query like the follows, if we want
to allow this:
> select carrier, ArrTime, max(depTime) from myTable GROUP BY carrier
IIRC, SQLite returns the ArrTime corresponding to the max(DepTime). Can we
check what Postgres does?
For aggregation functions like sum, mean where this doesn't make sense,
should we return any arbitrary value? If that's the case, I think it's not SQL
compliant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
