rohityadav1993 commented on code in PR #13837: URL: https://github.com/apache/pinot/pull/13837#discussion_r1723370245
########## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ########## @@ -49,6 +50,8 @@ public class PinotSinkFunction<T> extends RichSinkFunction<T> implements Checkpo public static final int DEFAULT_EXECUTOR_POOL_SIZE = 5; public static final long DEFAULT_EXECUTOR_SHUTDOWN_WAIT_MS = 3000; + public static final String DEFAULT_UPLOADED_REALTIME_SEGMENT_PREFIX = "flink"; Review Comment: No prefernece here, the segment naming convention implies uploaded realtime segment, so putting uploaded in prefix seems redundant. Let me know if you see any issues from minion operations perspective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
