gortiz commented on code in PR #13867:
URL: https://github.com/apache/pinot/pull/13867#discussion_r1725115771


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -388,7 +388,7 @@ private SuccessResponse addSchema(Schema schema, boolean 
override, boolean force
       // Best effort notification. If controller fails at this point, no 
notification is given.
       LOGGER.info("Notifying metadata event for adding new schema {}", 
schemaName);
       _metadataEventNotifierFactory.create().notifyOnSchemaEvents(schema, 
SchemaEventType.CREATE);
-
+      LOGGER.info("Successfully created new schema: {}", schema);

Review Comment:
   I know it is repetitive, but in order to make it easier to find these 
lines... can we have a pattern closer to the update log? something like:
   
   ```
   LOGGER.info("Successfully created schema: {} with value", schemaName, 
schema);
   ```
   
   That way we can look for the regexp `Successfully (created|updated) schema: 
schemaImLookingFor`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to